Lazy clients, client DI, and expose client health check #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, thanks! |
|
Note, I cannot merge this until I have released the existing in-limbo packages (there is a NuGet bug holding this up). |
I suppose you're referring to hosting/otel packages, any eta on releasing those to nugetorg? Is there an issue tracking nuget bug? |
Hopefully soon, no ETA. |
Sushisource
approved these changes
Jul 17, 2023
| @@ -12,13 +17,14 @@ namespace Temporalio.Client | |||
| /// </summary> | |||
| public sealed class TemporalConnection : ITemporalConnection | |||
| { | |||
| private readonly Bridge.Client client; | |||
| // Not set if not lazy | |||
| private readonly SemaphoreSlim? semaphoreForLazyClient; | |||
There was a problem hiding this comment.
SemaphoreSlim sounds like a great rapper name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
TemporalClient.CreateLazyandTemporalConnection.CreateLazyfor those wanting to create client but not connect until laterITemporalConnection.IsConnectedproperty andITemporalConnection.ConnectAsyncinstance method to support lazy connectionsIServiceCollection.AddTemporalClientextension methods for creating DI-based lazy singleton client (one returns an option builder, the other accepts an action to configure)