Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document/enforce SignalWithStartWorkflow does not use same workflow ID option as ExecuteWorkflow #603

Closed
cretz opened this issue Oct 26, 2021 · 0 comments · Fixed by #612
Closed

Document/enforce SignalWithStartWorkflow does not use same workflow ID option as ExecuteWorkflow #603

cretz opened this issue Oct 26, 2021 · 0 comments · Fixed by #612
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Oct 26, 2021

Is your feature request related to a problem? Please describe.

SignalWithStartWorkflow uses the workflowID parameter like SignalWorkflow instead of the ID in options like ExecuteWorkflow. That means the function accepts ID in two ways and ignores one.

Describe the solution you'd like

Document that the ID in options is disallowed and error if it is provided and is different than the workflowID parameter.
@cretz cretz added the enhancement New feature or request label Oct 26, 2021
cretz added a commit to cretz/temporal-sdk-go that referenced this issue Nov 1, 2021
@cretz
Document ambiguous ID and test for mismatch
26c553e 
Fixes temporalio#603
@cretz cretz mentioned this issue Nov 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document ambiguous ID and test for mismatch on signal start cretz/temporal-sdk-go
1 participant
@cretz