Handle CanceledAfterStarted in CanceledEvent #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Feb 2, 2023
| @@ -1161,6 +1161,57 @@ func testReplayWorkflowCancelChildWorkflowUnusualOrdering(ctx Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (s *internalWorkerTestSuite) TestReplayWorkflowHistory_ChildWorkflowCancellation_WhenWorkflowCanceled() { | |||
There was a problem hiding this comment.
Can you replicate the failure in an integration test? Seems straightforward enough to wait for a child workflow to start and then cancel its parent and confirm the parent panicked/WFT-failed before this fix.
(sorry, I just trust integration tests much more than manual history creation)
There was a problem hiding this comment.
No fair point I'll make an integration test, I will say this manual history is basically what the customers history looked like
cretz
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User reported this issue where I believe they tried to cancel a workflow that had a child workflow and it resulted in the parent workflow getting stuck panicing on invalid state transition on the
ChildWorkflowExecutionCanceledbecause it didn't expect it to be inCanceledAfterStarted. I don't see why we would treatCanceledAfterInitiateddifferently thanCanceledAfterStartedso I allowed the state transition.Previously the SDK would consider this an invalid state transition and panic, now the SDK handles it as a canceled child workflow.