Error on Registering Activity with Workflow Context #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The original issue said to warn, but I figured this was equivalent as there was a flag to bypass failing functions. I've also not worked that closely with reflection so I'm open to alterations. |
cretz
approved these changes
Apr 20, 2023
Quinn-With-Two-Ns
approved these changes
Apr 20, 2023
|
LGTM, just need to fix the unit test |
Quinn-With-Two-Ns
force-pushed
the
shannontan/checkActivityContext
branch
2 times, most recently
from
e3ce0a4 to
fb1142b
Compare
|
Looking at the error, I think this is unrelated to my PR? Let me know if it I'm misreading. |
|
@shannonjmtan yep unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Check for workflow context usage within activity arguments as this is usually developer error (accidental and misunderstanding). Note that this would likely fail later on anyways when executing the function.
Why?
Prevent accidental errors.
Checklist
Closes Warn on calling an
ExecuteActivityon a function that takes aworkflow.Context#1061How was this tested: Added unit tests for new behavior, existing tests should verify current behavior.
Any docs updates needed? No as this is not stated as an allowed behavior (nor will it even work).