Fix history paging on looking for WFT Fail #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jun 23, 2023
| if nextIndex >= len(eh.loadedEvents) && eh.hasMoreEvents() { // current page ends and there is more pages | ||
| // Server can return an empty page so if we need the next event we must keep checking until we either get it | ||
| // or know we have no more pages to check | ||
| for nextIndex >= len(eh.loadedEvents) && eh.hasMoreEvents() { // current page ends and there is more pages |
There was a problem hiding this comment.
Ug. One might expect such a loop to be in loadMoreEvents and loadMoreEvents have docs that says "This will not return until it has actually loaded more events or there are no more events". But I guess this way the history iterator is non-blocking.
Sushisource
approved these changes
Jun 23, 2023
Quinn-With-Two-Ns
force-pushed
the
history_paging
branch
from
535d88e to
395095a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the Go SDK more robust to empty pages from the server when running
IsNextWorkflowTaskFailed.I saw without the change to
IsNextWorkflowTaskFailedthe unit testTestEmptyPageswould return different events and messages if I used theMockHistoryIteratorto return empty pages every other request or not.