Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing spelling errors in comments #1188

Merged
merged 2 commits into from
Aug 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ type (
GetWorkflowHistory(ctx context.Context, workflowID string, runID string, isLongPoll bool, filterType enumspb.HistoryEventFilterType) HistoryEventIterator

// CompleteActivity reports activity completed.
// activity Execute method can return acitivity.activity.ErrResultPending to
tsolodov marked this conversation as resolved.
Show resolved Hide resolved
// activity Execute method can return activity.ErrResultPending to
// indicate the activity is not completed when it's Execute method returns. In that case, this CompleteActivity() method
// should be called when that activity is completed with the actual result and error. If err is nil, activity task
// completed event will be reported; if err is CanceledError, activity task canceled event will be reported; otherwise,
Expand Down
2 changes: 1 addition & 1 deletion internal/error.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Below are the possible types of internal error:
what kind of error it was and take actions based on it. The details is encoded payload which workflow code could extract
to strong typed variable. Workflow code needs to know what the types of the encoded details are before extracting them.
- If activity implementation returns errors other than from NewApplicationError() API. In this case GetOriginalType()
will return orginal type of an error represented as string. Workflow code could check this type to determine what kind of error it was
will return original type of an error represented as string. Workflow code could check this type to determine what kind of error it was
and take actions based on the type. These errors are retryable by default, unless error type is specified in retry policy.
2) *CanceledError:
If activity was canceled, internal error will be an instance of *CanceledError. When activity cancels itself by
Expand Down
2 changes: 1 addition & 1 deletion internal/schedule_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ type (

// ScheduleHandle represents a created schedule.
ScheduleHandle interface {
// GetID returns the schedule ID asssociated with this handle.
// GetID returns the schedule ID associated with this handle.
GetID() string

// Delete the Schedule
Expand Down
4 changes: 2 additions & 2 deletions internal/session.go
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ func CreateSession(ctx Context, sessionOptions *SessionOptions) (Context, error)
// returns an error under the same situation as CreateSession() or the token passed in is invalid.
// It also has the same usage as CreateSession().
//
// The main usage of RecreateSession is for long sessions that are splited into multiple runs. At the end of
// The main usage of RecreateSession is for long sessions that are split into multiple runs. At the end of
// one run, complete the current session, get recreateToken from sessionInfo by calling SessionInfo.GetRecreateToken()
// and pass the token to the next run. In the new run, session can be recreated using that token.
func RecreateSession(ctx Context, recreateToken []byte, sessionOptions *SessionOptions) (Context, error) {
Expand Down Expand Up @@ -232,7 +232,7 @@ func CompleteSession(ctx Context) {
// even though the creation activity has been canceled, the session worker doesn't know. The worker will wait until
// next heartbeat to figure out that the workflow is completed and then release the resource. We need to make sure the
// completion activity is executed before the workflow exits.
// the taskqueue will be overrided to use the one stored in sessionInfo.
// the taskqueue will be overridden to use the one stored in sessionInfo.
err := ExecuteActivity(completionCtx, sessionCompletionActivityName, sessionInfo.SessionID).Get(completionCtx, nil)
if err != nil {
GetLogger(completionCtx).Warn("Complete session activity failed", tagError, err)
Expand Down