Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify GetLastCompletionResult works with schedule #1225

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Clarify GetLastCompletionResult works with schedule #1225

merged 1 commit into from
Sep 5, 2023

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Clarify GetLastCompletionResult works with schedules as well as cron

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner September 5, 2023 14:46
cretz
cretz approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting some internal clarification on how this is accomplished from the scheduler workflow (I wonder if server is using some special API known only to them), but assuming this is accurate, LGTM.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 591ce7e into temporalio:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz