Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable keep alive by default #1299

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Enable keep alive by default #1299

merged 1 commit into from
Nov 30, 2023

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns commented Nov 22, 2023 •
edited
Loading

Enabled keep alive by default.

#1248

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review November 27, 2023 16:17
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner November 27, 2023 16:17
cretz
cretz reviewed Nov 27, 2023
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantic: May want to remove "TCP" from issue title (this is gRPC keep alive which is HTTP/2 keep alive using HTTP/2 pings, TCP keep alive is a separate thing).

internal/client.go Outdated Show resolved Hide resolved
@Quinn-With-Two-Ns Quinn-With-Two-Ns changed the title Enabled TCP keep alive by default Enable keep alive by default Nov 27, 2023
cretz
cretz approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Reminder to add a big 💥 message to the release notes :-)

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 89c8dba into temporalio:master Nov 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz