Use our new JSON coding stack #1307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeebswihart
commented
Nov 28, 2023
Comment on lines
+1466
to
1481
| defer func() { | ||
| closeErr := reader.Close() | ||
| if closeErr != nil && err == nil { | ||
| err = closeErr | ||
| } else if closeErr != nil { | ||
| ilog.NewDefaultLogger().Warn("failed to close json file", "path", jsonfileName, "error", closeErr) | ||
| } | ||
| }() | ||
|
|
||
| hist := &historypb.History{} | ||
| dec := temporalproto.NewJSONDecoder(reader, true) | ||
| if err := dec.Decode(hist); err != nil { | ||
| opts := temporalproto.CustomJSONUnmarshalOptions{ | ||
| DiscardUnknown: true, | ||
| } | ||
|
|
||
| bs, err := io.ReadAll(reader) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
Previously we would leak the file if decoding failed
cretz
approved these changes
Nov 28, 2023
|
NOTE: I will fix the feature tests once this repo merges |
tdeebswihart
deleted the
compatible-json-harder-better-faster-stronger
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I updated go-api to use the less-shoddy JSON coder I added to temporalproto.
Why?
Better performance while still supporting old-style JSON