Bump api-go version to fix Payload marshaling #1308
Merged
+22
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can see from temporalio/features#375 that the feature tests pass when that repo has been updated |
cretz
approved these changes
Nov 29, 2023
|
API repo is tagged, I'll set this to merge once tests pass |
I keep forgetting about this
In the future we'll keep unreleased SDK versions out of the main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
I upgraded our api-go dependency
Why?
Marshaling for binary/null payloads was completely broken, and while there Chad and I decided that shorthand marshaling should be opt-in rather than opt-out.