Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race in WaitSignalReturnParam #1309

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix race in WaitSignalReturnParam #1309

merged 1 commit into from
Nov 30, 2023

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

TestWorkflowIDReuseIgnoreDuplicateWhileRunning was failing because the workflow WaitSignalReturnParam was exiting before receiving the second signal.

Fixes https://github.com/temporalio/sdk-go/actions/runs/7040203549/job/19160706031

@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the fix-WaitSignalReturnParam branch from d916da0 to 96e4572 Compare November 30, 2023 17:21
@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review November 30, 2023 17:23
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner November 30, 2023 17:23
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 266e049 into temporalio:master Nov 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @Sushisource