Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle nil valuePtr case in update handler Get #1373

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Handle nil valuePtr case in update handler Get #1373

merged 1 commit into from
Feb 1, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Avoid passing a nil to EncocedValue.Get. This matches the behaviour of other Get calls in the SDK

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner February 1, 2024 20:51
dandavison
dandavison approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 86764f8 into temporalio:master Feb 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

@dandavison dandavison dandavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quinn-With-Two-Ns @dandavison @cretz