Experimental cloud operations client #1462
Conversation
# Conflicts: # contrib/datadog/go.mod # contrib/datadog/go.sum # contrib/opentelemetry/go.mod # contrib/opentelemetry/go.sum # contrib/opentracing/go.mod # contrib/opentracing/go.sum # contrib/tally/go.mod # contrib/tally/go.sum # go.mod # go.sum # test/go.mod # test/go.sum
# Conflicts: # contrib/datadog/go.mod # contrib/datadog/go.sum # contrib/opentelemetry/go.mod # contrib/opentelemetry/go.sum # contrib/opentracing/go.mod # contrib/opentracing/go.sum # contrib/tally/go.mod # contrib/tally/go.sum # go.mod # go.sum # internal/cmd/build/go.mod # internal/cmd/build/go.sum # test/go.mod # test/go.sum
test/cloud_test.go
Outdated
|
|
||
| func init() { flag.BoolVar(&cloudTestsFlag, "cloud-tests", false, "Enable cloud tests") } | ||
|
|
||
| func TestCloudSuite(t *testing.T) { |
There was a problem hiding this comment.
Nit: Can we rename this to something like TestCloudOpsSuit or similar to clarify these tests are just for the clouds Ops API.
There was a problem hiding this comment.
I can change this. I was actually thinking that this could encompass all cloud-only tests and not just operations ones (granted it's only operations tests today that are cloud only and we create that client in setup).
There was a problem hiding this comment.
What kind of tests would be cloud-only that aren't the cloud ops tests?
We have other tests that already run against cloud https://github.com/temporalio/sdk-go/actions/runs/9784335348/job/27014986110, but I guess they are not cloud only.
There was a problem hiding this comment.
I am not sure, but we can refactor when we get there (maybe we'll never there)
What was changed
client.CloudOperationsClientCloudService(), but has room for high-level wrappers if we ever want themclient.DialCloudOperationsClient()andclient.CloudOperationsClientOptionsUsers must deal w/ a required version header and an API key that can only live for a limited time during the current beta cloud API. We decided we'll no longer block this issue on those experience concerns.
(this was started in #1426, but moved to local branch to run cloud tests)
Checklist