Fix gauge metrics with latest otel SDK #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
May 21, 2024
Comment on lines
+7
to
+9
| go.opentelemetry.io/otel v1.23.0 | ||
| go.opentelemetry.io/otel/sdk v1.23.0 | ||
| go.opentelemetry.io/otel/trace v1.23.0 |
There was a problem hiding this comment.
I assume 1.23 instead of 1.26 just because we want lowest-working version?
There was a problem hiding this comment.
Yeah, this was the lowest version that our old implementation broke on
| @@ -130,12 +130,20 @@ func (m MetricsHandler) Counter(name string) client.MetricsCounter { | |||
| func (m MetricsHandler) Gauge(name string) client.MetricsGauge { | |||
| // TODO(https://github.com/open-telemetry/opentelemetry-go/issues/3984) replace with sync gauge once supported | |||
| var config atomic.Value | |||
| config.Store(0.0) | |||
| _, err := m.meter.Float64ObservableGauge(name, | |||
| metric.WithFloat64Callback(func(ctx context.Context, o metric.Float64Observer) error { | |||
There was a problem hiding this comment.
Hrmm, were you able to dig up what changed on their side for why this callback doesn't work for us anymore? I am just curious, if not no worries.
There was a problem hiding this comment.
I wasn't able to find what exact commit broke it unfortunately
Quinn-With-Two-Ns
force-pushed
the
issue-1477
branch
from
31a554d to
2e0549b
Compare
Quinn-With-Two-Ns
force-pushed
the
issue-1477
branch
from
2e0549b to
61d67c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported here there appears to be a change in behaviour in Go OTEL SDK library when creating multiple gauges with the same name. Now only the first callbacks registered callback is used and all others are ignored. This causes some metrics to be missing. To work around this until
SyncGaugeis released in the Go SDK I switched to usingRegisterCallbackas these callbacks are still called.While working in this area I also made it so gauges don't emit zero if no value has been reported.