Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flake in TestUpdateAdmittedNoWorker #1506

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fix flake in TestUpdateAdmittedNoWorker #1506

merged 1 commit into from
Jun 10, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Test was flaking I suspect from a race between stopping the worker and sending the update. Fix is to not even attempt to start the worker.

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner June 6, 2024 22:59
@Quinn-With-Two-Ns
Fix flake in TestUpdateAdmittedNoWorker
3cada5a 
Don't even attempt to start the worker
@Quinn-With-Two-Ns Quinn-With-Two-Ns force-pushed the fix-flake-TestUpdateAdmittedNoWorker branch from 74cdf68 to 3cada5a Compare June 7, 2024 16:25
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit d4ff1f6 into temporalio:master Jun 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz