Update some docs around grpc Dial options #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
approved these changes
Jun 14, 2024
cretz
approved these changes
Jun 17, 2024
Quinn-With-Two-Ns
force-pushed
the
update-grpc-dial-docs
branch
from
fd7878a to
f48aeca
Compare
Quinn-With-Two-Ns
force-pushed
the
update-grpc-dial-docs
branch
from
f48aeca to
d8ff6f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update some docs around grpc Dial options because
grpc-godeprecatedgrpc.Dialso we switched togrpc.NewClientthat doesn't support some of these dial options because they are anti patterns not recommended by the gRPC team.https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md
Another thing we could do is add a flag to use the old deprecated client options to help who did rely on these options.