Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception… #1524

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception… #1524

merged 2 commits into from
Jun 22, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner June 20, 2024 20:47
cretz
cretz approved these changes Jun 20, 2024
View reviewed changes
client/client.go Outdated
//
// Note, this is not related to any general concept of timing out or cancelling a running update, this is only related to the client call itself.
// NOTE: Experimental
WorkflowUpdateRPCTimeoutOrCancelledError = internal.WorkflowUpdateRPCTimeoutOrCancelledError
Copy link
Member

@cretz cretz Jun 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used RPC because it's RPCError in Python to differentiate between RPC and non-RPC errors (e.g. if we have an actual update timeout error one day which is different than this one). But Go uses the serviceerror package to differentiate RPC errors. So if you want, you could change this to WorkflowUpdateServiceTimeoutOrCancelledError or something like that, unsure. But I'm fine with this too.

cretz
cretz reviewed Jun 20, 2024
View reviewed changes
client/client.go Outdated
//
// Note, this is not related to any general concept of timing out or cancelling a running update, this is only related to the client call itself.
// NOTE: Experimental
WorkflowUpdateRPCTimeoutOrCancelledError = internal.WorkflowUpdateRPCTimeoutOrCancelledError
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you would like, you can only use one l, e.g. WorkflowUpdateRPCTimeoutOrCanceledError, since that's what we do at https://pkg.go.dev/go.temporal.io/api/serviceerror#Canceled. Different languages do different things there.

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 652b15d into temporalio:master Jun 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception for Update
2 participants
@Quinn-With-Two-Ns @cretz