Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utility to get metrics handler for a Nexus operation #1559

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Add utility to get metrics handler for a Nexus operation #1559

merged 2 commits into from
Jul 24, 2024

Conversation

bergundy
Copy link
Member

This is work done by @pdoerner in #1544 that was lost in the nexus feature branch merge.

@pdoerner @bergundy
Add utility to get metrics handler for a Nexus operation (temporalio#…
51fc925 
…1544)

* Add utility to get metrics handler for a Nexus operation

* tidy

* Add GetLogger and update tests

* Revert "tidy"

This reverts commit bd02887.
@bergundy bergundy requested a review from a team as a code owner July 23, 2024 17:23
@bergundy bergundy merged commit 9c40461 into temporalio:master Jul 24, 2024
13 checks passed
@bergundy bergundy deleted the nexus-metrics-logger branch July 24, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdoerner pdoerner pdoerner approved these changes

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bergundy @cretz @Quinn-With-Two-Ns @pdoerner