Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for WorkflowIdConflictPolicy #1563

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Support for WorkflowIdConflictPolicy #1563

merged 2 commits into from
Jul 26, 2024

Conversation

stephanos
Copy link
Contributor

@stephanos stephanos commented Jul 24, 2024 •
edited
Loading

What was changed

Added WorkflowIdConflictPolicy to ExecuteWorkflow and SignalWithStart.

NOTE: I haven't seen any WorkflowIdReusePolicy validation inside of testsuite.WorkflowTestSuite (except for child workflows), so I didn't add any for the WorkflowIdConflictPolicy either.

Checklist

Closes #1447

@stephanos stephanos force-pushed the workflowidconflictpolicy branch 5 times, most recently from a0034ff to 319dd3b Compare July 25, 2024 02:13
@stephanos stephanos force-pushed the workflowidconflictpolicy branch from 319dd3b to 8b38e37 Compare July 25, 2024 03:49
@stephanos stephanos marked this pull request as ready for review July 25, 2024 04:08
@stephanos stephanos requested a review from a team as a code owner July 25, 2024 04:08
@cretz
Copy link
Member

cretz commented Jul 25, 2024

@stephanos - can you also make sure this is added for ScheduleWorkflowAction?

@stephanos
Copy link
Contributor Author

stephanos commented Jul 25, 2024 •
edited
Loading

@cretz I might be missing something, but when I looked at the schedule code I saw it's not using StartWorkflowOptions anywhere and therefore doesn't have either WorkflowIdReusePolicy or WorkflowIdConflictPolicy fields?

@cretz
Copy link
Member

cretz commented Jul 25, 2024

My mistake, this is not needed, I was confusing with languages that reused common sets of start options.

@stephanos stephanos enabled auto-merge (squash) July 26, 2024 15:50
@stephanos stephanos merged commit 1f0296c into temporalio:master Jul 26, 2024
13 checks passed
@stephanos stephanos deleted the workflowidconflictpolicy branch July 26, 2024 18:40
stephanos added a commit to stephanos/sdk-go that referenced this pull request Aug 5, 2024
@stephanos
Support for WorkflowIdConflictPolicy (temporalio#1563)
125dc48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

@Quinn-With-Two-Ns Quinn-With-Two-Ns Awaiting requested review from Quinn-With-Two-Ns

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for WorkflowIdConflictPolicy
2 participants
@stephanos @cretz