Include updateID and updateName in update logger #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Oct 8, 2024
Quinn-With-Two-Ns
force-pushed
the
issue-1648
branch
from
906fb99 to
df85dbf
Compare
yuandrew
approved these changes
Oct 8, 2024
| @@ -278,7 +278,11 @@ func GetCurrentUpdateInfo(ctx Context) *UpdateInfo { | |||
| return internal.GetCurrentUpdateInfo(ctx) | |||
| } | |||
|
|
|||
| // GetLogger returns a logger to be used in workflow's context | |||
| // GetLogger returns a logger to be used in workflow's context. | |||
| // This logger does not record logs during replay. | |||
ReyOrtiz
pushed a commit
to ReyOrtiz/temporal-sdk-go
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include updateID and updateName in update logger.
closes #1648