Error if history contains unexpected events after the StartedEventId #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quinn-With-Two-Ns
force-pushed
the
error-on-stale-history
branch
from
d25d6ae to
67a5e61
Compare
cretz
reviewed
Oct 8, 2024
| // In such cases, the SDK should return error indicating that the workflow task is stale since the result will not be used. | ||
| if size > 0 && lastEventID > 0 && | ||
| h.Events[size-1].GetEventId() > lastEventID { | ||
| return nil, nil, fmt.Errorf("history contains events past expected last event ID (%v) "+ |
There was a problem hiding this comment.
Can you confirm that an error iterating here is treated as task failure (eviction and all of that)?
Quinn-With-Two-Ns
force-pushed
the
error-on-stale-history
branch
from
67a5e61 to
1e1039f
Compare
cretz
approved these changes
Oct 8, 2024
Quinn-With-Two-Ns
force-pushed
the
error-on-stale-history
branch
from
1e1039f to
07060f8
Compare
ReyOrtiz
pushed a commit
to ReyOrtiz/temporal-sdk-go
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error if history contains unexpected events after the StartedEventId