Add regression test to validate temporal_workflow_task_execution_failed on replay #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Oct 15, 2024
Quinn-With-Two-Ns
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a new test to test the temporal_workflow_task_execution_failed metric is logged when replaying a closed workflow hits NDE.
Why?
This metric failed to log in 1.26.0, but does today. Add a test to monitor for a regression with this behavior.
Checklist
Closes temporal_workflow_task_execution_failed not emitted on replay #1441
How was this tested:
New integration test passes
3. Any docs updates needed?