Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestNonDeterminismFailureCauseReplay integration test #1674

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Fix TestNonDeterminismFailureCauseReplay integration test #1674

merged 1 commit into from
Oct 16, 2024

Conversation

yuandrew
Copy link
Contributor

What was changed

Stop checking for specific error for QueryWorkflow that we expect to fail.

Why?

Sometimes we hit Context deadline exceeded, and sometimes we hit query timed out before a worker could process it, which is the server hitting context deadline exceeded.

Checklist

  1. Closes temporal_workflow_task_execution_failed not emitted on replay #1441

  2. How was this tested:

  1. Any docs updates needed?

@yuandrew yuandrew requested a review from a team as a code owner October 16, 2024 17:48
@yuandrew yuandrew merged commit cfc38de into temporalio:master Oct 16, 2024
13 checks passed
@yuandrew yuandrew deleted the TestNonDeterminismFailureCauseReplay-fix branch October 16, 2024 20:37
ReyOrtiz pushed a commit to ReyOrtiz/temporal-sdk-go that referenced this pull request Dec 5, 2024
@yuandrew @reynieroz
Fix TestNonDeterminismFailureCauseReplay integration test (temporalio…
eadcf03 
…#1674)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

temporal_workflow_task_execution_failed not emitted on replay
2 participants
@yuandrew @Quinn-With-Two-Ns