Dedup duplicate update IDs for test environment #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuandrew
commented
Oct 29, 2024
yuandrew
commented
Nov 4, 2024
…t second update coming in before first one completes, and fixed code that test revealed
Quinn-With-Two-Ns
approved these changes
Nov 25, 2024
ReyOrtiz
pushed a commit
to ReyOrtiz/temporal-sdk-go
that referenced
this pull request
Dec 5, 2024
* PR feedback * Push to ask slack question * test passes * cleanup * more cleanup * handle error properly, better guard rails for passing env * potential solution to multiple async updates * add wrapper the user can't see * remove fail line used for debugging * add mutex to ensure multiple updates are properly processed * forgot to remove stale code * forgot updateworkflowbyid * handle in-flight updates, with debug prints * prints removed * clean up tests * added check in tests to ensure all updates completed, add test to test second update coming in before first one completes, and fixed code that test revealed * switch to use new TestUpdateCallback utility
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added functionality in test environment to cache update
Why?
Match non-test behavior
Checklist
Closes Workflow Update in Test Environment should dedup updates by ID #1638
How was this tested:
new test written
Any docs updates needed?