Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for errors.Is() #523

Merged
merged 4 commits into from
Sep 8, 2021
Merged

Conversation

laniehei
Copy link
Member

@laniehei laniehei commented Aug 30, 2021

Resolves #403

@laniehei laniehei requested review from Sushisource and vitarb August 30, 2021 06:00
@laniehei laniehei requested a review from mfateev as a code owner August 30, 2021 06:00
Copy link
Contributor

@vitarb vitarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comment, otherwise LGTM.

@vitarb
Copy link
Contributor

vitarb commented Aug 31, 2021

Also linter complains about missing comments (see build output).

@laniehei laniehei enabled auto-merge (squash) September 1, 2021 05:58
@laniehei laniehei merged commit cc674e0 into temporalio:master Sep 8, 2021
@laniehei laniehei deleted the errors-is branch September 9, 2021 16:25
laniehei added a commit that referenced this pull request Sep 9, 2021
laniehei added a commit that referenced this pull request Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use errors.Is to check a returned error
3 participants