Header support for signals and queries #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
requested review from
alexshtin,
bergundy,
mfateev,
Spikhalskiy,
Sushisource and
vitarb
as code owners
Spikhalskiy
approved these changes
Nov 23, 2021
mmcshane
approved these changes
Nov 23, 2021
…y-header # Conflicts: # go.mod # go.sum # test/integration_test.go
…y-header # Conflicts: # test/go.mod
|
Now that temporalio/temporal#2149 is in a tagged release, the integration tests confirming the behavior have been added here and we can now merge this. |
This was referenced Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added header support for signals and queries as implemented server-side in temporalio/temporal#2149.
Why?
So that people can put metadata on them and they can be traced.
Checklist