Disallow MaxConcurrentWorkflowTaskPollers to be set to 1 #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
requested review from
mfateev,
Sushisource,
alexshtin,
Spikhalskiy,
bergundy and
mmcshane
as code owners
Sushisource
reviewed
Feb 14, 2022
cretz
force-pushed
the
max-conc-poller
branch
from
ea91842 to
c56447d
Compare
Sushisource
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Disallow MaxConcurrentWorkflowTaskPollers to be set to 1
Why?
Because worker polling is built to require at least 2 due to how stickiness preference is implemented.
Checklist