Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Updates #811

Merged
merged 1 commit into from
May 23, 2022
Merged

CI Updates #811

merged 1 commit into from
May 23, 2022

Conversation

cretz
Copy link
Member

@cretz cretz commented May 23, 2022 •
edited
Loading

What was changed

  • Remove BuildKite (we have reached full parity in GH actions)
  • Add coveralls to GH actions
  • Remove a couple other seemingly unnecessary files

Why?

  • GH actions gives us more control and is clearer to our open source users
  • Other SDKs are using GH actions too

@cretz cretz marked this pull request as ready for review May 23, 2022 15:04
@cretz
Copy link
Member Author

cretz commented May 23, 2022

I have already disabled BuildKite from their side (but not removed of course). After this is merged, I will remove their webhook.

alexshtin
alexshtin approved these changes May 23, 2022
View reviewed changes
.travis.yml
@@ -1,36 +0,0 @@
dist: trusty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this file manage to survive that long?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 Sometimes I find remnants of the fork here and there.

@alexshtin
Copy link
Member

You are in the loop now. You can't merge it until you remove it.

@cretz
Copy link
Member Author

cretz commented May 23, 2022 •
edited
Loading

You are in the loop now. You can't merge it until you remove it.

@alexshtin - In GH admin I removed build kite from being a required check, so I can merge it right now since you've given approval. I will let it sit for a couple more hours though if anyone has anything to say.

@cretz cretz merged commit 41cd853 into master May 23, 2022
@cretz cretz deleted the ci-update branch May 23, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshtin alexshtin alexshtin approved these changes

@mfateev mfateev Awaiting requested review from mfateev

@Sushisource Sushisource Awaiting requested review from Sushisource

@Spikhalskiy Spikhalskiy Awaiting requested review from Spikhalskiy

@bergundy bergundy Awaiting requested review from bergundy

@mmcshane mmcshane Awaiting requested review from mmcshane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cretz @alexshtin