Support alias disabling during workflow/activity registration #850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add
worker.Options.DisableRegistrationAliasing
(andworker.WorkflowReplayerOptions.DisableRegistrationAliasing
andtestsuite.WorkflowTestSuite.DisableRegistrationAliasing
) to opt-out of registration aliasing which we strongly recommend (I would love to make this default, but can't due to compatibility concerns).Why?
Did you know that today, if you register
foo()
with custom name"bar"
and registerbaz()
with custom name"foo"
, when you invoke using the string name"foo"
, you will actually executefoo()
?Did you know that today, if you register
pkga.foo()
with no custom name and then registerpkgb.foo()
with custom name"bar"
, when you invoke using the function referencepkga.foo
, you will actually callpkgb.foo()
?This is wrong but unchangeable since people may inadvertently rely on such behavior. Rather, we now have a way to opt-out of this bad behavior. It is that second "Did you know" above that is the justification for putting this as a worker-level option instead of a register-option when registering.
Checklist