Rewrite service proxy and interceptor to use new api-go code. #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Dec 5, 2022
cretz
reviewed
Dec 7, 2022
cretz
reviewed
Dec 13, 2022
Co-authored-by: Chad Retz <chad@temporal.io>
cretz
reviewed
Dec 15, 2022
cretz
approved these changes
Dec 16, 2022
|
temporalio/api-go#100 now merged, just waiting on a new release before updating this. |
|
@robholland - https://github.com/temporalio/api-go has now been tagged as 1.14.0 whenever you want to update this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
SDK code refactored to use new api-go APIs.
Why?
This is done to avoid tightly coupling sdk-go package to api versions, see: #971
Checklist
Closes Move most interceptor/proxy-based code gen to api-go #971
How was this tested:
Existing test coverage adjusted to suit.
Any docs updates needed?
No.