StateMachine rewrite

build.gradle

@@ -120,7 +120,7 @@ configurations.all {
 
 license {
     header rootProject.file('license-header.txt')
-    exclude 'io/temporal/proto/**.java' // generated code
+    exclude '**/*.puml'
 }
 
 task initSubmodules(type: Exec) {
@@ -170,8 +170,8 @@ protobuf {
 
 idea {
     module {
-        sourceDirs += file("$buildDir/generated/main/java");
-        sourceDirs += file("$buildDir/generated/main/grpc");
+        sourceDirs += file("$buildDir/generated/main/java")
+        sourceDirs += file("$buildDir/generated/main/grpc")
     }
 }
 
@@ -327,15 +327,15 @@ allprojects {
     // add a testlistener to all tasks of type Test
     tasks.withType(Test) {
         afterTest { TestDescriptor descriptor, TestResult result ->
-            if(result.resultType == org.gradle.api.tasks.testing.TestResult.ResultType.FAILURE){
+            if (result.resultType == org.gradle.api.tasks.testing.TestResult.ResultType.FAILURE) {
                 failedTests << ["${descriptor.className}::${descriptor.name}"]
             }
         }
     }
 
     // print out tracked failed tests when the build has finished
     gradle.buildFinished {
-        if(!failedTests.empty){
+        if (!failedTests.empty) {
             println "Failed tests for ${project.name}:"
             failedTests.each { failedTest ->
                 println failedTest

src/main/java/io/temporal/activity/ActivityOptions.java

@@ -185,7 +185,7 @@ public ActivityOptions validateAndBuildWithDefaults() {
           taskQueue,
           retryOptions,
           contextPropagators,
-          cancellationType);
+          cancellationType == null ? ActivityCancellationType.TRY_CANCEL : cancellationType);
     }
   }
 

src/main/java/io/temporal/client/WorkflowOptions.java

@@ -263,15 +263,15 @@ public WorkflowOptions validateBuildWithDefaults() {
 
   private final String taskQueue;
 
-  private RetryOptions retryOptions;
+  private final RetryOptions retryOptions;
 
-  private String cronSchedule;
+  private final String cronSchedule;
 
-  private Map<String, Object> memo;
+  private final Map<String, Object> memo;
 
-  private Map<String, Object> searchAttributes;
+  private final Map<String, Object> searchAttributes;
 
-  private List<ContextPropagator> contextPropagators;
+  private final List<ContextPropagator> contextPropagators;
 
   private WorkflowOptions(
       String workflowId,

src/main/java/io/temporal/common/converter/EncodedValues.java

@@ -27,7 +27,7 @@
 public final class EncodedValues implements Values {
   private Optional<Payloads> payloads;
   private DataConverter converter;
-  private Object[] values;
+  private final Object[] values;
 
   public EncodedValues(Optional<Payloads> payloads, DataConverter converter) {
     this.payloads = Objects.requireNonNull(payloads);

src/main/java/io/temporal/common/interceptors/WorkflowOutboundCallsInterceptor.java

@@ -129,4 +129,6 @@ void registerSignal(
   void upsertSearchAttributes(Map<String, Object> searchAttributes);
 
   Object newThread(Runnable runnable, boolean detached, String name);
+
+  long currentTimeMillis();
 }

src/main/java/io/temporal/common/interceptors/WorkflowOutboundCallsInterceptorBase.java

@@ -166,4 +166,9 @@ public void upsertSearchAttributes(Map<String, Object> searchAttributes) {
   public Object newThread(Runnable runnable, boolean detached, String name) {
     return next.newThread(runnable, detached, name);
   }
+
+  @Override
+  public long currentTimeMillis() {
+    return next.currentTimeMillis();
+  }
 }

src/main/java/io/temporal/failure/ApplicationFailure.java

@@ -120,7 +120,7 @@ public void setDataConverter(DataConverter converter) {
   }
 
   private static String getMessage(String message, String type, boolean nonRetryable) {
-    return (Strings.isNullOrEmpty(message) ? "" : "message='" + message + "\', ")
+    return (Strings.isNullOrEmpty(message) ? "" : "message='" + message + "', ")
         + "type='"
         + type
         + '\''

src/main/java/io/temporal/failure/CanceledFailure.java

@@ -22,13 +22,14 @@
 import io.temporal.common.converter.DataConverter;
 import io.temporal.common.converter.EncodedValues;
 import io.temporal.common.converter.Values;
+import java.util.Objects;
 
 public final class CanceledFailure extends TemporalFailure {
   private final Values details;
 
   public CanceledFailure(String message, Values details, Throwable cause) {
     super(message, message, cause);
-    this.details = details;
+    this.details = Objects.requireNonNull(details);
   }
 
   public CanceledFailure(String message, Object details) {

src/main/java/io/temporal/failure/FailureConverter.java

@@ -66,11 +66,11 @@ public class FailureConverter {
 
   private static final Pattern TRACE_ELEMENT_PATTERN = Pattern.compile(TRACE_ELEMENT_REGEXP);
 
-  public static Exception failureToException(Failure failure, DataConverter dataConverter) {
+  public static RuntimeException failureToException(Failure failure, DataConverter dataConverter) {
     if (failure == null) {
       return null;
     }
-    Exception result = failureToExceptionImpl(failure, dataConverter);
+    RuntimeException result = failureToExceptionImpl(failure, dataConverter);
     if (result instanceof TemporalFailure) {
       ((TemporalFailure) result).setFailure(failure);
     }
@@ -81,8 +81,9 @@ public static Exception failureToException(Failure failure, DataConverter dataCo
     return result;
   }
 
-  private static Exception failureToExceptionImpl(Failure failure, DataConverter dataConverter) {
-    Exception cause =
+  private static RuntimeException failureToExceptionImpl(
+      Failure failure, DataConverter dataConverter) {
+    RuntimeException cause =
         failure.hasCause() ? failureToException(failure.getCause(), dataConverter) : null;
     switch (failure.getFailureInfoCase()) {
       case APPLICATION_FAILURE_INFO:

src/main/java/io/temporal/internal/common/WorkflowExecutionUtils.java

@@ -96,7 +96,7 @@ public class WorkflowExecutionUtils {
 
   private static final Logger log = LoggerFactory.getLogger(WorkflowExecutionUtils.class);
 
-  private static RpcRetryOptions retryParameters =
+  private static final RpcRetryOptions retryParameters =
       RpcRetryOptions.newBuilder()
           .setBackoffCoefficient(2)
           .setInitialInterval(Duration.ofMillis(500))
@@ -813,6 +813,7 @@ public static boolean isCommandEvent(HistoryEvent event) {
     return result;
   }
 
+  /** Returns event that corresponds to a command. */
   public static EventType getEventTypeForCommand(CommandType commandType) {
     switch (commandType) {
       case COMMAND_TYPE_SCHEDULE_ACTIVITY_TASK:
@@ -830,7 +831,7 @@ public static EventType getEventTypeForCommand(CommandType commandType) {
       case COMMAND_TYPE_CANCEL_WORKFLOW_EXECUTION:
         return EventType.EVENT_TYPE_WORKFLOW_EXECUTION_CANCELED;
       case COMMAND_TYPE_REQUEST_CANCEL_EXTERNAL_WORKFLOW_EXECUTION:
-        return EventType.EVENT_TYPE_EXTERNAL_WORKFLOW_EXECUTION_CANCEL_REQUESTED;
+        return EventType.EVENT_TYPE_REQUEST_CANCEL_EXTERNAL_WORKFLOW_EXECUTION_INITIATED;
       case COMMAND_TYPE_RECORD_MARKER:
         return EventType.EVENT_TYPE_MARKER_RECORDED;
       case COMMAND_TYPE_CONTINUE_AS_NEW_WORKFLOW_EXECUTION:

src/main/java/io/temporal/internal/context/ContextThreadLocal.java

@@ -30,7 +30,7 @@
 /** This class holds the current set of context propagators */
 public class ContextThreadLocal {
 
-  private static WorkflowThreadLocal<List<ContextPropagator>> contextPropagators =
+  private static final WorkflowThreadLocal<List<ContextPropagator>> contextPropagators =
       WorkflowThreadLocal.withInitial(
           new Supplier<List<ContextPropagator>>() {
             @Override