ScheduleClient for SpringBoot #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
cretz
reviewed
Jul 14, 2023
...lpha/src/main/java/io/temporal/spring/boot/autoconfigure/RootNamespaceAutoConfiguration.java
Show resolved
Hide resolved
cretz
reviewed
Jul 14, 2023
...lpha/src/main/java/io/temporal/spring/boot/autoconfigure/RootNamespaceAutoConfiguration.java
Outdated
Show resolved
Hide resolved
…oral/spring/boot/autoconfigure/RootNamespaceAutoConfiguration.java Co-authored-by: Chad Retz <chad.retz@gmail.com>
Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>
cretz
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
LGTM, but you may want @Quinn-With-Two-Ns or @mjameswh's review before merging.
| TemporalOptionsCustomizer<WorkflowClientOptions.Builder> clientCustomizer) { | ||
| TemporalOptionsCustomizer<WorkflowClientOptions.Builder> clientCustomizer, | ||
| @Autowired(required = false) @Nullable | ||
| TemporalOptionsCustomizer<ScheduleClientOptions.Builder> scheduleCustomize) { |
There was a problem hiding this comment.
Question, can you or your tests confirm that, due to type erasure, these last two parameters are properly treated as separate things by Spring?
There was a problem hiding this comment.
agree we need customization tests for this. will try to add
Quinn-With-Two-Ns
approved these changes
Jul 14, 2023
|
LGTM thanks @tsurdilo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support to autowire ScheduleClient.
Schedule apis are not yet implemented for test env so if you have idea what other test can be added please let me know.
Closes #1812