[WIP] Fix CI after GHA's drop of node16 actions #2332
Conversation
| - name: Build native test server | ||
| run: ./gradlew :temporal-test-server:build | ||
| run: | |
There was a problem hiding this comment.
Is there a reason you didn't run this task in a container?
There was a problem hiding this comment.
Oops! Missed a commit. That will make more sense now.
There was a problem hiding this comment.
Wouldn't this step still make sense to run in a container?
There was a problem hiding this comment.
The container parameter only exists at the job-level. Steps run with whatever runner/container was set by the job.
A possible alternative is to use a docker image as an action, but there are a few limitations to that approach. But trying it that now to see if that would work.
| run: | | ||
| docker run \ | ||
| --rm -v "$(pwd):/workspace" -w /workspace \ | ||
| ghcr.io/graalvm/graalvm-community:21-ol7 \ |
There was a problem hiding this comment.
Also the graal compiler should come from our plugin not the environment so why did you need to use a graal docker image here?
There was a problem hiding this comment.
Replaced by openjdk:21-jdk-oraclelinux7.
…than "run docker"
What was changed
Modified our GHA workflows so that when building the native executable of the Test Server on Linux targets, only the actual compilation step runs inside an older GLIBC 2.17-based Docker container; all other operations are performed directly on the runner, which can now be any recent Ubuntu.
This was required because GHA no longer allows actions based on Node16 (i.e. actions are forced to use Node20 instead), but Node20 requires at least GLIBC 2.28. It is therefore not possible to have a single execution environment that can both execute Node20-based actions, yet produces native binaries that can then execute on the GLIBC 2.17-based environments that some of our users have.
Fixes [Bug] CI build will soon get broken due to GHA dropping support for node16-based actions #2331.