-
Notifications
You must be signed in to change notification settings - Fork 166
Fix non-root namespace bean injection timing issue (#2579) #2600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
B. Johnson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
injection timing issue (temporalio#2579)
b649055
to
ee07e21
Compare
Hey thanks for the contribution, I will make sure to review this as soon as I can. Either today or tomorrow. Can we make sure we test the specific scenario brought up in the issue as well #2579? Basically ensure we can inject a non-root bean like a non-root client, Thanks! |
@Quinn-With-Two-Ns changing this to a draft actually while I think about it a bit more. Updated |
…lized rather than to ensure proper dependency order. (temporalio#2579)
…lized rather than to ensure proper dependency order. (temporalio#2579)
Slight change to my original proposed fix - added |
@expanded-for-real I don't think |
@Quinn-With-Two-Ns I was able to create a test that basically mimicked the timing issue (which became |
Fixes timing issue where non-root namespace beans were created too late in the Spring lifecycle as described in 2579. This is fixed by modifying
NonRootBeanPostProcessor
to trigger bean creation when the root namespace template is actually ready as opposed to triggering on any bean initialization