Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Binary Protobuf Converter into default set #455

Closed
roxblnfk opened this issue Jun 12, 2024 · 0 comments · Fixed by #468
Closed

Add Binary Protobuf Converter into default set #455

roxblnfk opened this issue Jun 12, 2024 · 0 comments · Fixed by #468
Assignees
@roxblnfk
Labels
Bug Something isn't working
Milestone
2.10.3

Comments

@roxblnfk
Copy link
Collaborator

roxblnfk commented Jun 12, 2024 •
edited
Loading

We have no ability to decode messages converted with binary/protobuf.

The converter should be added after the ProtoJsonConverter.
In this case PHP SDK will be able to decode binary/protobuf messages, and json/protobuf converter will still be used for marshalling by default.
@roxblnfk roxblnfk mentioned this issue Jun 12, 2024
Open
27 tasks
@roxblnfk roxblnfk added this to the 2.10.3 milestone Jun 18, 2024
@roxblnfk roxblnfk added the Bug Something isn't working label Jun 20, 2024
@roxblnfk roxblnfk mentioned this issue Jul 1, 2024
Merged
@roxblnfk roxblnfk self-assigned this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roxblnfk roxblnfk

Labels
Bug Something isn't working
Projects
None yet
Milestone
2.10.3
Development

Successfully merging a pull request may close this issue.

Add ProtoBinary decoder in default set temporalio/sdk-php
1 participant
@roxblnfk