Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PHP SDK integration #485

Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

[WIP] PHP SDK integration #485

wants to merge 73 commits into from

Conversation

roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented May 21, 2024

What was changed

Added runner preparation:

  • configuring SDK version
  • downloading PHP vendor packages
  • downloading RoadRunner
  • do it in a separated directory

Added runner that runs RoadRunner and starts PHP features in a single run.

Implemented features:

Checklist

How to run

go build -o temporal-features
./temporal-features run --lang php

Windows:

go build -o temporal-features.exe
./temporal-features.exe run --lang php

…erun RoadRunner; add `query/timeout_due_to_no_active_workers` feature
@roxblnfk
Copy link
Collaborator Author

roxblnfk commented Jun 19, 2024

Looks like we need to register the temporaliotest/features:php docker image

UPD:
Added TODO about registering the image there https://github.com/temporalio/docker-builds/blob/main/.github/workflows/features-integration.yml

@roxblnfk
Copy link
Collaborator Author

roxblnfk commented Oct 8, 2024

About this option:

Adding this test requires adjustments to the framework because RR needs to be restarted with special worker settings.
I'm not sure it's worth spending time on it right now.

@roxblnfk roxblnfk marked this pull request as ready for review October 8, 2024 22:04
@roxblnfk
Copy link
Collaborator Author

roxblnfk commented Oct 8, 2024

Ready for review.
You don't need to spend effort reviewing PHP files.
For the most part, they are the same tests that are also run in the PHP-SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] PHP harness
1 participant