Use environment options to create RRActivityInvocationCache #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Not sure if the test failures are related to the change? in theory the environment returns the same value if the envvar is not set so there should be no real change in behaviour. |
This is not related to the changes 👌 The tests pass successfully but sometimes end with a wrong code. It's something Windows-specific that still needs to be investigated #501 |
roxblnfk
approved these changes
Oct 28, 2024
roxblnfk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
For the ActivityMocker invocation cache a hard-coded address was used for the roadrunner RPC settings, in certain scenarios it is desirable to change it. This is inline with other parts of the code that set the RPC address.
Why?
On my local PC i am running temporal/roadrunner combination for local development purposes
For PHPUnit tests i am spinning up the temporal-test-server (for the time shifting ability) and another roadrunner which connects to this temporal server. The RPC settings on the second roadrunner need to be different to not clash with the first process.
Checklist
Closes
How was this tested:
Tested by making changes locally
Any docs updates needed?
None