Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve deprecations #523

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Resolve deprecations #523

merged 8 commits into from
Nov 7, 2024

Conversation

roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented Nov 5, 2024

What was changed

  • Fix deprecation on Service Client exception parsing
  • Resolve all the deprecations in tests
  • Deprecate ScheduleSpec::$excludeCalendarList and related methods; stop mapping it into the related protobuf message

Why?

It may throw an error depending on user environment

Checklist

  1. Closes [Bug] [ErrorException] exclude_calendar is deprecated. #522
  2. Closes Repair tests in CI #501 (tests on windows are run only with protobuf ext)

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 0:59am

@roxblnfk roxblnfk merged commit a271938 into 2.11 Nov 7, 2024
10 checks passed
@roxblnfk roxblnfk deleted the resolve-deprecations branch November 7, 2024 17:25
@roxblnfk roxblnfk linked an issue Nov 14, 2024 that may be closed by this pull request
@roxblnfk roxblnfk added this to the 2.11.3 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repair tests in CI
2 participants