Adds basedpyright support to poe format
#1240
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) -> None: | ||
| self._default_runtime: Runtime | None = None | ||
| self._prevent_default = False | ||
| self._default_created = False |
Contributor
There was a problem hiding this comment.
I actually think this is just a mistake in the other line setting this value. I must have just missed it when I originally added this. So line 40 should be deleted along with this one. Can just leave this and open an issue though if that's easier.
| @overload | ||
| def start_local_activity_class( | ||
| activity: type[CallableAsyncNoParam[ReturnType]], | ||
| activity: Type[CallableAsyncNoParam[ReturnType]], # type: ignore[reportDeprecated] |
Contributor
There was a problem hiding this comment.
I changed some of these to type as part of #1137. Any reason we shouldn't change them all to type rather than Type with these ignores?
| await workflow_handle.result() | ||
|
|
||
|
|
||
| def test_summary_extraction(): |
Contributor
There was a problem hiding this comment.
Was this just tested elsewhere? Or not valuable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Checklist
Closes
How was this tested: