fix(proto): protobuf exports may be incorrect if minimized (#1279)

Author: mjameswh

packages/common/src/converter/protobuf-payload-converters.ts

@@ -192,7 +192,8 @@ function resetBufferInGlobal(hasChanged: boolean): void {
 function isProtobufType(type: unknown): type is Type {
   return (
     isRecord(type) &&
-    type.constructor.name === 'Type' &&
+    // constructor.name may get mangled by minifiers; thanksfuly protobufjs also sets a className property
+    (type.constructor as any).className === 'Type' &&
     hasOwnProperties(type, ['parent', 'name', 'create', 'encode', 'decode']) &&
     typeof type.name === 'string' &&
     typeof type.create === 'function' &&
@@ -214,7 +215,8 @@ function getNamespacedTypeName(node: Type | Namespace): string {
 }
 
 function isRoot(root: unknown): root is Root {
-  return isRecord(root) && root.constructor.name === 'Root';
+  // constructor.name may get mangled by minifiers; thanksfuly protobufjs also sets a className property
+  return isRecord(root) && (root.constructor as any).className === 'Root';
 }
 
 export interface DefaultPayloadConverterWithProtobufsOptions {

packages/proto/src/patch-protobuf-root.ts

@@ -53,11 +53,13 @@ type Type = Record<string, unknown>;
 type Namespace = { nested: Record<string, unknown> };
 
 function isType(value: unknown): value is Type {
-  return isRecord(value) && value.constructor.name === 'Type';
+  // constructor.name may get mangled by minifiers; thanksfuly protobufjs also sets a constructor.className property
+  return isRecord(value) && (value.constructor as any).className === 'Type';
 }
 
 function isNamespace(value: unknown): value is Namespace {
-  return isRecord(value) && value.constructor.name === 'Namespace';
+  // constructor.name may get mangled by minifiers; thanksfuly protobufjs also sets a constructor.className property
+  return isRecord(value) && (value.constructor as any).className === 'Namespace';
 }
 
 // Duplicate from type-helpers instead of importing in order to avoid circular dependency

packages/test/src/test-patch-root.ts

@@ -23,11 +23,15 @@ test('patchRoot', (t) => {
 });
 
 class Namespace {
+  public static className = 'Namespace';
+
   constructor(props: Record<string, unknown>) {
     for (const key in props) {
       (this as any)[key] = props[key];
     }
   }
 }
 
-class Type {}
+class Type {
+  public static className = 'Type';
+}