fix(proto): protobuf exports may be incorrect if minimized #1279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
In a few places, we reflectively visit and transform our protobuf definitions. To determine the type of node being visited (Root, Namespace or Type), we would previously check the object's
constructor.name. However, that name could get mangled if the package was bundled and minimized, which would generally result in error messages such as:We now check
constructor.classNameinstead, which is a convenient property added by the protobufjs library, specifically for the purpose of reflection.Note
@temporalio/*packages as part of bundled and/or minimized applications. We do not test such usage at this time. We strongly recommend configuring your bundler to treat these packages as external.