startUpdate require wait stage #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
sdk-1403-startUpdate-require-wait-stage
branch
2 times, most recently
from
ea8d425
to
84e2c11
Compare
dandavison
commented
Jun 21, 2024
dandavison
force-pushed
the
sdk-1403-startUpdate-require-wait-stage
branch
from
84e2c11
to
bbb01ef
Compare
dandavison
added a commit
to dandavison/temporalio-features
that referenced
this pull request
Jul 2, 2024
|
This is ready for review now. temporalio/features#504 updates the features repo to be compatible with the backwards-incompatible SDK changes made in this PR. |
dandavison
force-pushed
the
sdk-1403-startUpdate-require-wait-stage
branch
2 times, most recently
from
9eabfe8
to
79fa903
Compare
mjameswh
reviewed
Jul 9, 2024
mjameswh
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1403
What was changed
Make
startUpdaterequireWhy?
We decided to require this to make it explicit that the call -- despite being named
startXXX-- blocks until a worker is available and accepts/rejects the update.