Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Reset reapply type option missing from reset-batch #239

Open
tszucs-stripe opened this issue Jul 29, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@tszucs-stripe
Copy link

tszucs-stripe commented Jul 29, 2022

Is your feature request related to a problem? Please describe.

We needed to reset ~600 workflows in production due to a bug, and wanted to use the
reset-batch command to do this. It was useful both because it is a batch operation, and because of the --only_non_deterministic option to ensure we only reset workflows experiencing the issue.

Unfortunately, we wanted to also do the reset without reapplying previous events, to prevent each workflow from immediately reprocessing 1K signals post-reset. But the --reset_apply_type option is missing in the reset-batch command, but is available in the reset command.

But with querying, it was not clear how we could target workflows in a similar fashion as --only_non_deterministic. So instead we had to aggregate logs and create a CSV of workflows to reset, which added significant time to our remediation, and then run a reset command on each of those..

Describe the solution you'd like

It would be nice if reset-batch contained all of the options from reset, but in particular the --reset_reapply_type option.

Additional context

Also posted another issue from this particular incident at #240.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant