Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Run reset-batch as an internal workflow within Temporal #240

Open
tszucs-stripe opened this issue Jul 29, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@tszucs-stripe
Copy link

Is your feature request related to a problem? Please describe.

Running reset-batch on a large number of workflows can be problematic, as the resetting is done within the CLI and not within an internal workflow. This can be a risk within remediation of an incident because we are relying on the connection between a laptop and the temporal server which could have several failures and/or rate-limiters.

Describe the solution you'd like

It would be great if reset-batch was ran as an internal workflow within Temporal, like some of the other commands. This would help ensure reliability and improve remediation speed in the case of an incident with a large number of workflows.

Additional context

Also posted another issue from this particular incident at #239.

@feedmeapples
Copy link
Contributor

we are updating the batch APIs https://github.com/temporalio/api/blob/master/temporal/api/batch/v1/message.proto

asked the server team about adding the reset API, i'll keep you posted

@feedmeapples
Copy link
Contributor

discussing with @yiminc @yux0 this and resetting open child workflows, which one to take on first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants