Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
--tls
flag to app.flags slice--tls
flag with checking on error. And added the logic that when the flag is activated, the host is taken from the address/localhost--tls
flag name--tls
flag to app.flags slice--tls
flag with checking on error. And added the logic that when the flag is activated, the host is taken from the address/localhostWhy?
I am connecting to my server over a TLS connection and I had to duplicate my host from the
--address
flag to the--tls_server_name
flag. This cluttered up the command, as well as misleading.Checklist
Closes #146
How was this tested:
Related to same issue
temporalio/cli#210