Skip to content

Commit

Permalink
Revert change to default reapply type (#5688)
Browse files Browse the repository at this point in the history
## What changed?
Revert change to default enum value made in #5360

## Why?
We cannot deploy a change that both introduces a new value and starts
using it as the default, since during rollout it may cause a frontend
client on the new version to send a value that is unknown to a history
node on the old version.

## How did you test it?
I didn't

## Potential risks
No risk

## Is hotfix candidate?
This change should be cherry-picked onto current release candidates.
  • Loading branch information
dandavison authored and dnr committed Apr 9, 2024
1 parent 63e70c2 commit 21ac7f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion common/enums/defaults.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func SetDefaultContinueAsNewInitiator(f *enumspb.ContinueAsNewInitiator) {

func SetDefaultResetReapplyType(f *enumspb.ResetReapplyType) {
if *f == enumspb.RESET_REAPPLY_TYPE_UNSPECIFIED {
*f = enumspb.RESET_REAPPLY_TYPE_ALL_ELIGIBLE
*f = enumspb.RESET_REAPPLY_TYPE_SIGNAL
}
}

Expand Down

0 comments on commit 21ac7f0

Please sign in to comment.