[Nexus] Add logs when failed to parse links

temporalio · Aug 26, 2024 · a303710 · a303710
1 parent 7103b82
commit a303710
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/components/nexusoperations/executors.go b/components/nexusoperations/executors.go
@@ -339,7 +339,11 @@ func (e taskExecutor) saveResult(ctx context.Context, env hsm.Environment, ref h
 					case string((&commonpb.Link_WorkflowEvent{}).ProtoReflect().Descriptor().FullName()):
 						link, err := ConvertNexusLinkToLinkWorkflowEvent(nexusLink)
 						if err != nil {
-							// silently ignore for now
+							// TODO(rodrigozhou): ignore error for now
+							e.Logger.Error(
+								fmt.Sprintf("failed to parse link to %q: %s", nexusLink.Type, nexusLink.URL),
+								tag.Error(err),
+							)
 							continue
 						}
 						links = append(links, &commonpb.Link{

diff --git a/service/frontend/nexus_handler.go b/service/frontend/nexus_handler.go
@@ -393,7 +393,8 @@ func (h *nexusHandler) StartOperation(
 			for _, link := range t.AsyncSuccess.GetLinks() {
 				linkURL, err := url.Parse(link.Url)
 				if err != nil {
-					// silently ignore for now
+					// TODO(rodrigozhou): ignore error for now
+					oc.logger.Error(fmt.Sprintf("failed to parse link url: %s", link.Url), tag.Error(err))
 					continue
 				}
 				nexusLinks = append(nexusLinks, nexus.Link{