Skip to content

Commit

Permalink
Remove track_total_hits from Scroll API (#6592)
Browse files Browse the repository at this point in the history
## What changed?
<!-- Describe what has changed in this PR -->
Remove track_total_hits from Scroll API

## Why?
<!-- Tell your future self why have you made these changes -->
`track_total_hits` cannot be disable in Scroll API.

Issue: #6566

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
  • Loading branch information
rodrigozhou authored and dnr committed Oct 4, 2024
1 parent d1e8bcd commit d5482f1
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,6 @@ func (c *clientImpl) OpenScroll(
Index(p.Index).
Query(p.Query).
SortBy(p.Sorter...).
TrackTotalHits(false).
KeepAlive(keepAliveInterval)
if p.PageSize != 0 {
scrollService.Size(p.PageSize)
Expand Down

0 comments on commit d5482f1

Please sign in to comment.