-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace sqlite3 with modernc #2704
Conversation
Plz try to run go samples / canary locally as sanity tests |
I have run a few of the samples locally against this, canary is a good one to try as well. |
👋 really excited about this! Heads up that Temporalite supports |
Would you be willing to send a PR with a unit/integration test for this case? We can land that test case and then rebase on top of that. ** edit below ** Once this PR lands a change will need to happen in temporalite how the pragmas flow from cli options to dsn encoding. More details can be found here, https://gitlab.com/cznic/sqlite/-/blob/master/all_test.go |
I don't have bandwidth at the moment, but happy to follow up after this is merged. Before communicating that the sqlite driver is production ready, we should also probably document what level of backwards compatibility we can guarantee for the driver's configuration options. |
What changed?
Replaced sqlite module with pure go implementation
Why?
Towards removing CGO run temporal docker images
How did you test it?
Local unit tests and sample execution
Added memory and file variant tests for sqlite for future proofing
Potential risks
Typical risks with changing persistence dependency modules
The underlying module change does change how connection dsn is built
until schema migration becomes supported there are no implicit backwards compatibility guarantees.
Is hotfix candidate?
No
Build times
Canary execution