Refactor history cache to its own package #3601
Conversation
There was a problem hiding this comment.
Plz... can it be called workflow cache, instead of history cache as it's caching workflow mutable state instead of workflow history events? All the variable names are also workflowCache. And I remember there're some refactor before (either in temporal or cadence repo) to change the name from historyCache to workflow cache.
Is it possible to create the new package under workflow? Like service/history/workflow/cache?
Sounds good. I'm just curious about, why |
|
| archiveIfEnabled bool, | ||
| stage *tasks.DeleteWorkflowExecutionStage, | ||
| ) error | ||
| } | ||
|
|
||
| DeleteManagerImpl struct { | ||
| shard shard.Context | ||
| historyCache Cache | ||
| workflowCache wcache.Cache |
| @@ -68,20 +66,20 @@ type ( | |||
| } | |||
|
|
|||
| ActivityReplicatorImpl struct { | |||
| historyCache workflow.Cache | |||
| workflowCache wcache.Cache | |||
| @@ -113,7 +113,7 @@ type ( | |||
| historySerializer serialization.Serializer | |||
| metricsHandler metrics.MetricsHandler | |||
| namespaceRegistry namespace.Registry | |||
| historyCache workflow.Cache | |||
| workflowCache wcache.Cache | |||
| @@ -66,7 +67,7 @@ type ( | |||
| controller *gomock.Controller | |||
| mockShard *shard.ContextTest | |||
| mockEventCache *events.MockCache | |||
| mockHistoryCache *workflow.MockCache | |||
| mockWorkflowCache *wcache.MockCache | |||
| @@ -154,7 +154,7 @@ type ( | |||
| transactionMgrImpl struct { | |||
| shard shard.Context | |||
| namespaceRegistry namespace.Registry | |||
| historyCache workflow.Cache | |||
| workflowCache wcache.Cache | |||
| @@ -82,7 +82,7 @@ type ( | |||
| namespaceRegistry namespace.Registry | |||
| clusterMetadata cluster.Metadata | |||
| executionMgr persistence.ExecutionManager | |||
| historyCache workflow.Cache | |||
| workflowCache wcache.Cache | |||
| @@ -89,7 +89,7 @@ func newQueueProcessorBase( | |||
| options *QueueProcessorOptions, | |||
| queueProcessor common.Daemon, | |||
| queueAckMgr queueAckMgr, | |||
| historyCache workflow.Cache, | |||
| wcache wcache.Cache, | |||
| @@ -22,9 +22,9 @@ | |||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
| // THE SOFTWARE. | |||
|
|
|||
| //go:generate mockgen -copyright_file ../../../LICENSE -package $GOPACKAGE -source $GOFILE -destination cache_mock.go | |||
| //go:generate mockgen -copyright_file ../../../../LICENSE -package $GOPACKAGE -source $GOFILE -destination cache_mock.go | |||
| ) | ||
|
|
||
| type ( | ||
| historyCacheSuite struct { | ||
| workflowCacheSuite struct { |
| @@ -105,7 +106,7 @@ func (s *WorkflowTaskHandlerCallbackSuite) SetupTest() { | |||
| s.mockEventsCache.EXPECT().PutEvent(gomock.Any(), gomock.Any()).AnyTimes() | |||
| s.logger = mockShard.GetLogger() | |||
|
|
|||
| historyCache := workflow.NewCache(mockShard) | |||
| workflowCache := wcache.NewCache(mockShard) | |||
What changed?
Refactored history cache to its own package. Together Refactored DeleteManager to its package to avoid circular imports.
Why?
Code preparation for: #3594
How did you test it?
Unit tests, CI,
make binsPotential risks
Low risk as unit tests and builds are passing; this is just package renaming—no logic change.
Is hotfix candidate?
None